Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missed thread_exit() to vdev_{autotrim,rebuild}_thread #10668

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Add missed thread_exit() to vdev_{autotrim,rebuild}_thread #10668

merged 2 commits into from
Aug 5, 2020

Conversation

mattmacy
Copy link
Contributor

@mattmacy mattmacy commented Aug 3, 2020

Signed-off-by: Matt Macy [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@ghost ghost added the Status: Code Review Needed Ready for review and testing label Aug 3, 2020
@lundman
Copy link
Contributor

lundman commented Aug 4, 2020

Ooo I missed one, nice!

@codecov
Copy link

codecov bot commented Aug 4, 2020 •
edited
Loading

Codecov Report

Merging #10668 into master will decrease coverage by 14.89%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #10668       +/-   ##
===========================================
- Coverage   79.82%   64.92%   -14.90%     
===========================================
  Files         394      312       -82     
  Lines      124653   107437    -17216     
===========================================
- Hits        99502    69755    -29747     
- Misses      25151    37682    +12531
Flag Coverage Δ
#kernel ?
#user 64.92% <50.00%> (-1.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
module/zfs/vdev_rebuild.c 19.82% <0.00%> (-77.56%) ⬇️
module/zfs/vdev_trim.c 41.07% <100.00%> (-55.17%) ⬇️
module/zfs/objlist.c 0.00% <0.00%> (-100.00%) ⬇️
module/zfs/pathname.c 0.00% <0.00%> (-100.00%) ⬇️
include/sys/dmu_redact.h 0.00% <0.00%> (-100.00%) ⬇️
include/sys/dmu_traverse.h 0.00% <0.00%> (-100.00%) ⬇️
module/lua/ltablib.c 2.34% <0.00%> (-95.32%) ⬇️
module/zfs/bqueue.c 0.00% <0.00%> (-94.45%) ⬇️
module/zfs/zfs_rlock.c 0.00% <0.00%> (-94.21%) ⬇️
module/zcommon/zfs_deleg.c 0.00% <0.00%> (-92.46%) ⬇️
... and 239 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1de160...32c3b8a. Read the comment docs.

@ghost ghost changed the title Add missed thread_exit() to vdev_autotrim_thread Add missed thread_exit() to vdev_{autotrim,rebuild}_thread Aug 4, 2020
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 4, 2020
@behlendorf behlendorf merged commit 22dcf89 into openzfs:master Aug 5, 2020
@mattmacy mattmacy deleted the projects/vdev_autotrim_thread branch August 6, 2020 22:11
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@mattmacy @jsai20
Add missed thread_exit() to vdev_{autotrim,rebuild}_thread
aaa3795 
Reviewed-by: Jorgen Lundman <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Co-authored-by: Ryan Moeller <[email protected]>
Signed-off-by: Matt Macy <[email protected]>
Closes openzfs#10668
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@mattmacy
Add missed thread_exit() to vdev_{autotrim,rebuild}_thread
23ac5c5 
Reviewed-by: Jorgen Lundman <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Co-authored-by: Ryan Moeller <[email protected]>
Signed-off-by: Matt Macy <[email protected]>
Closes openzfs#10668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lundman lundman lundman approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattmacy @lundman @behlendorf